graph: Remove debug prefix from Timestamp value parse errors#6494
Closed
cuiweixie wants to merge 1 commit into
Closed
graph: Remove debug prefix from Timestamp value parse errors#6494cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
The TIMESTAMP_SCALAR branch accidentally formatted parse failures as "xxx{value}". Report the invalid input string directly, consistent with other ValueParseError paths.
Collaborator
|
The PR fails CI. Pushed commit 757ff94 which addresses the same thing correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an accidental
"xxx"debug prefix from theTIMESTAMP_SCALARbranch ofValue::from_graphql_value, soQueryExecutionError::ValueParseErrorreports the invalid timestamp string directly (consistent with other scalars).Testing
Please run
just lint,just check --release, and relevant unit tests locally before merge.